Gilad Chaplik has posted comments on this change.
Change subject: core: Introduce Change quota command - disks (#848310)
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/ChangeQuotaCommand.java
Line 26:
Line 27: @Override
Line 28: protected boolean canDoAction() {
Line 29: // check if SP exist
Line 30: setStoragePoolId(getParameters().getStoragePoolId());
Done
Line 31: if (getStoragePool() == null) {
Line 32:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_NOT_EXIST);
Line 33: return false;
Line 34: }
Line 28: protected boolean canDoAction() {
Line 29: // check if SP exist
Line 30: setStoragePoolId(getParameters().getStoragePoolId());
Line 31: if (getStoragePool() == null) {
Line 32:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_NOT_EXIST);
we have a separate bug for more informative quota messages
I will try to add it there.
Line 33: return false;
Line 34: }
Line 35: // Check if quota exist:
Line 36: if (getQuotaId() == null) {
Line 48: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 49: List<PermissionSubject> permissionList = new
ArrayList<PermissionSubject>();
Line 50: permissionList.add(new
PermissionSubject(getParameters().getQuotaId(),
Line 51: VdcObjectType.Quota,
Line 52: ActionGroup.CONSUME_QUOTA));
50/50
Line 53: return permissionList;
Line 54: }
Line 55:
Line 56: @Override
--
To view, visit http://gerrit.ovirt.org/7357
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0017a18109faecd1acab52897bba5474b6600390
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
