Allon Mureinik has posted comments on this change. Change subject: core: Fix storage allocation check when creating a VM snapshot ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/36889/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java: Line 141: Line 142: return toReturn; Line 143: } Line 144: Line 145: private boolean validateStorageDomains() { Let's find a better name for this, or at least separate domains and disks Line 146: List<DiskImage> vmDisksList = getDisksListForChecks(); Line 147: if (vmDisksList.size() > 0) { Line 148: DiskImagesValidator diskImagesValidator = createDiskImageValidator(vmDisksList); Line 149: if (!(validate(diskImagesValidator.diskImagesNotLocked()) -- To view, visit http://gerrit.ovirt.org/36889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I085d49dc90053e375f829900c75d2fe72c263161 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
