Liron Aravot has posted comments on this change.

Change subject: core: decouple recovery and reconstruct master domain
......................................................................


Patch Set 10: Code-Review+1

(1 comment)

minor comment

http://gerrit.ovirt.org/#/c/28443/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java:

Line 91:     }
Line 92: 
Line 93:     private StorageDomain getNewMasterDomain() {
Line 94:         if (newMasterDomain == null) {
Line 95:             newMasterDomain = 
getStorageDomainDAO().get(getParameters().getNewMasterDomainId());
please replace with = loadTargetMasterDomain()
Line 96:         }
Line 97:         return newMasterDomain;
Line 98:     }
Line 99: 


-- 
To view, visit http://gerrit.ovirt.org/28443
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c066b9ff4bebce899492fcc8b54bd6a2723b453
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to