Kanagaraj M has posted comments on this change. Change subject: webadmin : Start geo-rep session ......................................................................
Patch Set 5: (8 comments) http://gerrit.ovirt.org/#/c/32538/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 157: GlusterGeoRepSession selectedSession = (GlusterGeoRepSession)getSelectedItem(); Line 158: allowStartSessionCommand = selectedSession .getStatus() == GeoRepSessionStatus.NOTSTARTED || selectedSession.getStatus() == GeoRepSessionStatus.STOPPED; Line 159: } Line 160: } Line 161: getNewSessionCommand().setIsAvailable(true); duplicated Line 162: getRemoveSessionCommand().setIsAvailable(false); Line 163: getStartSessionCommand().setIsExecutionAllowed(allowStartSessionCommand); Line 164: getStopSessionCommand().setIsAvailable(false); Line 165: getSessionOptionsCommand().setIsAvailable(false); Line 188: setWindow(null); Line 189: } else if(command.getName().equalsIgnoreCase("closeConfirmWindow")) {//$NON-NLS-1$ Line 190: setConfirmWindow(null); Line 191: } else if(command.getName().equalsIgnoreCase("closeConfirmationWindow")) {//$NON-NLS-1$ Line 192: closeConfirmationWindow(); duplicate of "closeConfirmWindow"? Line 193: } else if(command.getName().equalsIgnoreCase("onStartGeoRepSession")) {//$NON-NLS-1$ Line 194: onStartGeoRepSession(); Line 195: } else if(command.getName().equalsIgnoreCase("closeWindow")) {//$NON-NLS-1$ Line 196: closeWindow(); Line 192: closeConfirmationWindow(); Line 193: } else if(command.getName().equalsIgnoreCase("onStartGeoRepSession")) {//$NON-NLS-1$ Line 194: onStartGeoRepSession(); Line 195: } else if(command.getName().equalsIgnoreCase("closeWindow")) {//$NON-NLS-1$ Line 196: closeWindow(); duplicate of "close"? Line 197: } Line 198: } Line 199: Line 200: private void closeWindow() { Line 205: if(getConfirmWindow() == null) { Line 206: return; Line 207: } else { Line 208: setConfirmWindow(null); Line 209: } you could just do setConfirmWindow(null); like above method Line 210: } Line 211: Line 212: private void startGeoRepSession() { Line 213: GlusterGeoRepSession selectedSession = (GlusterGeoRepSession) getSelectedItem(); Line 220: cModel.setHashName("volume_geo_rep_start_confirmation"); //$NON-NLS-1$ Line 221: Line 222: cModel.setMessage(constants.geoRepStartConfirmation()); Line 223: cModel.setForceLabel(constants.geoRepStartForce()); Line 224: cModel.getMasterVolume().setEntity(selectedSession.getMasterVolumeName() == null ? constants.notAvailableLabel() : selectedSession.getMasterVolumeName()); When will this be null? Line 225: cModel.getSlaveVolume().setEntity(selectedSession.getSlaveVolumeName()); Line 226: cModel.getSlaveHost().setEntity(selectedSession.getSlaveHostName()); Line 227: Line 228: UICommand okCommand = new UICommand("onStartGeoRepSession", this);//$NON-NLS-1$ Line 222: cModel.setMessage(constants.geoRepStartConfirmation()); Line 223: cModel.setForceLabel(constants.geoRepStartForce()); Line 224: cModel.getMasterVolume().setEntity(selectedSession.getMasterVolumeName() == null ? constants.notAvailableLabel() : selectedSession.getMasterVolumeName()); Line 225: cModel.getSlaveVolume().setEntity(selectedSession.getSlaveVolumeName()); Line 226: cModel.getSlaveHost().setEntity(selectedSession.getSlaveHostName()); You could move the above four lines to c'tor of GlusterVolumeGeoRepActionConfirmationModel, so that you can avoid the repetition in other action like stop/pause/resume Line 227: Line 228: UICommand okCommand = new UICommand("onStartGeoRepSession", this);//$NON-NLS-1$ Line 229: okCommand.setTitle(constants.ok()); Line 230: okCommand.setIsDefault(true); http://gerrit.ovirt.org/#/c/32538/5/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java: Line 289: Line 290: @DefaultStringValue("Geo-Replication") Line 291: String geoReplicationTitle(); Line 292: Line 293: @DefaultStringValue("Geo-Replication Start") Start Geo-Replicatiopn Line 294: String geoReplicationStartTitle(); Line 295: Line 296: @DefaultStringValue("Start Geo-replication Session ?") Line 297: String geoRepStartConfirmation(); Line 296: @DefaultStringValue("Start Geo-replication Session ?") Line 297: String geoRepStartConfirmation(); Line 298: Line 299: @DefaultStringValue("Force start session") Line 300: String geoRepStartForce(); provide a help icon stating what force means in the context Line 301: Line 302: @DefaultStringValue("Rebalance Status") Line 303: String volumeRebalanceStatusTitle(); Line 304: -- To view, visit http://gerrit.ovirt.org/32538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I46fbd79f714175e3ad3ce76d858714c6fec3fdde Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
