Martin Mucha has posted comments on this change. Change subject: webadmin: reverted removal of selectedItemsChanged method. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36899/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/macpool/SharedMacPoolListModel.java: Line 79: removeAllowed = false; Line 80: } else { Line 81: for (MacPool macPool : (Iterable<MacPool>) getSelectedItems()) { Line 82: if (macPool.isDefaultPool()) { Line 83: removeAllowed = false; > Please don't waste any more time on benchmarking this, of course it's negli it took only ~15 minutes and I got some knowledge out of it (which is move valuable that problem itself) I understand, that you find code clearer this way, I already pushed patch adding this break. Line 84: } Line 85: } Line 86: } Line 87: getRemoveCommand().setIsExecutionAllowed(removeAllowed); -- To view, visit http://gerrit.ovirt.org/36899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I473566cf0755519eb7fc922c435ae8a2ee545779 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
