Alon Bar-Lev has posted comments on this change. Change subject: core : Add engine sso ......................................................................
Patch Set 22: (1 comment) http://gerrit.ovirt.org/#/c/36119/22/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SSOUtils.java: Line 27: public static boolean isUserAuthenticated(HttpSession session) { Line 28: return session.getAttribute(SSO_PRINCIPAL_RECORD_ATTR_NAME) != null; Line 29: } Line 30: Line 31: public static void redirectToModule(HttpSession session, now I realized that you pass the auth record and principal record but removed the actual fields, although this is good behavior for the engine it is bad for integration with future 3rd party sso service and places that should not be aware of the records, such as reports. so best is to pass the important bits and the records so the remote party can consider what it supports. please use single json serialization for all information, you can prepare a map and serialize it to json easily. Line 32: HttpServletRequest request, Line 33: HttpServletResponse response) Line 34: throws IOException { Line 35: ExtMap principalRecord = (ExtMap) session.getAttribute(SSOUtils.SSO_PRINCIPAL_RECORD_ATTR_NAME); -- To view, visit http://gerrit.ovirt.org/36119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
