Amit Aviram has uploaded a new change for review. Change subject: webadmin: Moving allocation policy list box after storage domain in new disk widget. ......................................................................
webadmin: Moving allocation policy list box after storage domain in new disk widget. While changing storage domain in the new disk widget- the 'Allocation Policy' list box is changing accordingly. This patch moves the 'Allocation Policy' list box to be after the 'Storage Domain' list box to prevent a situation where the user selects options by order, and after choosing the policy, it will change when the user selects a domain without him noticing. Change-Id: Ia392bb8a6f0d2ebba65fe6ccc1ae5bf7a3e4df7e Bug-Url: https://bugzilla.redhat.com/1130116 Signed-off-by: Amit Aviram <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/37060/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java index 8464412..0090a91 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java @@ -91,11 +91,6 @@ ListModelListBoxEditor<DiskInterface> interfaceEditor; @UiField(provided = true) - @Path("volumeType.selectedItem") - @WithElementId("volumeType") - ListModelListBoxEditor<VolumeType> volumeTypeEditor; - - @UiField(provided = true) @Path("dataCenter.selectedItem") @WithElementId("dataCenter") ListModelListBoxEditor<StoragePool> datacenterEditor; @@ -104,6 +99,11 @@ @Path("storageDomain.selectedItem") @WithElementId("storageDomain") ListModelListBoxEditor<StorageDomain> storageDomainEditor; + + @UiField(provided = true) + @Path("volumeType.selectedItem") + @WithElementId("volumeType") + ListModelListBoxEditor<VolumeType> volumeTypeEditor; @UiField(provided = true) @Path("diskProfile.selectedItem") @@ -438,9 +438,9 @@ aliasEditor.setTabIndex(nextTabIndex++); descriptionEditor.setTabIndex(nextTabIndex++); interfaceEditor.setTabIndex(nextTabIndex++); - volumeTypeEditor.setTabIndex(nextTabIndex++); datacenterEditor.setTabIndex(nextTabIndex++); storageDomainEditor.setTabIndex(nextTabIndex++); + volumeTypeEditor.setTabIndex(nextTabIndex++); diskProfileEditor.setTabIndex(nextTabIndex++); quotaEditor.setTabIndex(nextTabIndex++); hostListEditor.setTabIndex(nextTabIndex++); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml index d9b3416..782ab67 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml @@ -72,9 +72,9 @@ <e:ListModelListBoxEditor ui:field="interfaceEditor" addStyleNames="{style.boxEditor}"/> <d:InfoIcon ui:field="interfaceInfoIcon" addStyleNames="{style.infoIcon}" visible="false"/> </g:HorizontalPanel> - <e:ListModelListBoxEditor ui:field="volumeTypeEditor" addStyleNames="{style.boxEditor}"/> <e:ListModelListBoxEditor ui:field="datacenterEditor" addStyleNames="{style.boxEditor}"/> <e:ListModelListBoxEditor ui:field="storageDomainEditor" addStyleNames="{style.boxEditor}"/> + <e:ListModelListBoxEditor ui:field="volumeTypeEditor" addStyleNames="{style.boxEditor}"/> <e:ListModelListBoxEditor ui:field="diskProfileEditor" addStyleNames="{style.boxEditor}"/> <e:ListModelListBoxEditor ui:field="quotaEditor" addStyleNames="{style.boxEditor}"/> <e:ListModelListBoxEditor ui:field="hostListEditor" addStyleNames="{style.boxEditor}"/> -- To view, visit http://gerrit.ovirt.org/37060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia392bb8a6f0d2ebba65fe6ccc1ae5bf7a3e4df7e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
