Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: hourglass in login (#849537) ......................................................................
Patch Set 2: Rebased and improved, with following changes (the original behavior is unchanged): * using UiCommandButton instead of SimpleDialogButton in LoginPopupView, so that we don't need to handle LoginCommand property changes (such as IsExecutionAllowed) manually * in LoginModel and UserPortalLoginModel, StartProgress() is called only after the model has been validated; model validation happens immediately so StartProgress() followed immediately by StopProgress() on failed validation has no sensible impact in UI Verified in both web and dev mode. The "wait" cursor disappears some time before main section UI is shown, this is because LoginModel calls StopProgress() [login operation has finished], but the application itself is still in transition to new GWTP place (default main section place = VMs main tab). In future, we should implement some visual notification mechanism to indicate when the application is transitioning from one place to another, e.g. some "Loading" message box displayed in the top center location of the page, for the duration of GWTP place transition. -- To view, visit http://gerrit.ovirt.org/7376 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4a4f4a8b20943e8fcfc37c076d7c8ad71e1d04a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
