Sharad Mishra has posted comments on this change.
Change subject: core: Refactored roles to RolesEntity.
......................................................................
Patch Set 1:
What is the ovirt recommended way to handle same name classes like in -
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/RoleMapper.java
If we change from RoleEntity to Role, then there will be two imports with same
name "Role". Should we refer to one of them by its complete package name?
*******
package org.ovirt.engine.api.restapi.types;
import org.ovirt.engine.api.model.Role;
import org.ovirt.engine.core.common.businessentities.RoleType;
import org.ovirt.engine.core.common.businessentities.Role;
import org.ovirt.engine.core.compat.Guid;
public class RoleMapper {
@Mapping(from = Role.class, to = Role.class)
public static Role map(Role entity, Role template) {
Role model = template != null ? template : new Role();
--
To view, visit http://gerrit.ovirt.org/7229
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idca1616161e2d1bbf3eae5d440fdf8209cafea34
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
