Eli Mesika has posted comments on this change.

Change subject: engine: DB persistent quartz scheduler
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.ovirt.org/#/c/36297/12/packaging/dbscripts/upgrade/03_06_0710_insert_quartz_tables.sql
File packaging/dbscripts/upgrade/03_06_0710_insert_quartz_tables.sql:

Line 12: DROP TABLE IF EXISTS qrtz_simprop_triggers CASCADE;
Line 13: DROP TABLE IF EXISTS qrtz_blob_triggers CASCADE;
Line 14: DROP TABLE IF EXISTS qrtz_triggers CASCADE;
Line 15: DROP TABLE IF EXISTS qrtz_job_details CASCADE;
Line 16: DROP TABLE IF EXISTS qrtz_calendars CASCADE;
Please remove all DROP (even if exists by mistake in other scripts)

upgrade scripts are planned to be executed only once so there is no point in 
keeping them re-entrant
Line 17: 
Line 18: CREATE TABLE qrtz_job_details
Line 19:   (
Line 20:     sched_name VARCHAR(120) NOT NULL,


-- 
To view, visit http://gerrit.ovirt.org/36297
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a34dac95999cb6b3721d201c116fb5f6089bb61
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to