Juan Hernandez has posted comments on this change.

Change subject: core/restapi/webadmin: Support clearing the cluster's emulated 
machine
......................................................................


Patch Set 2:

Do we already expose the "emulated_machine" as a property of the cluster? I 
think we don't, so the first step should be to add this:

  GET /clusters/{cluster:id}
  <cluster id="..." href="...">
    <name>mycluster</name>
    <emulated_machine>whatever</emulated_machine>
    ...
  </cluster>

Once we allow that for output we should then allow it for input, with the PUT 
method:

  PUT /clusters/{cluster:id}
  <cluster>
    <emulated_machine>whatever</emulated_machine>
  </cluster>

If we do so then we don't need an action to clear the value, just an empty 
element:

  PUT /clusters/{cluster:id}
  <cluster>
    <emulated_machine/>
  </cluster>

-- 
To view, visit http://gerrit.ovirt.org/37115
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e1f70cbbe46fa54edda3f0aa9e56bfd576b8266
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eldan Shachar <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to