Yair Zaslavsky has posted comments on this change.

Change subject: engine: Added new column 'fingerprint' in the vds_static table
......................................................................


Patch Set 2: (2 inline comments)

Do we want to expose this at VDS view as well?

....................................................
File 
backend/manager/dbscripts/upgrade/03_01_1360_add_fingerprint_column_to_vds_static.sql
Line 1: --Add fingerprint field into vds_static
File name is no longer relvant. 1360 is the script for adding rpm_version


Line 1: --Add fingerprint field into vds_static
Line 2: SELECT fn_db_add_column('vds_static', 'fingerprint', 'character 
varying(128)');
+1 on Alon's comment - let's try and be more elaborative on columns name.


--
To view, visit http://gerrit.ovirt.org/7171
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7abe03b62dc15bb135fa02e0a43b763abd8872af
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to