Shireesh Anjal has posted comments on this change.
Change subject: engine: Gluster server peer list command
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
Looks good. Minor comment inline.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterServersListReturnForXmlRpc.java
Line 40: }
Line 41: setServer(glusterServers);
Line 42: }
Line 43:
Line 44: private GlusterServerInfo prepareHostsEntity(Map<String, Object>
map) {
Now that you have renamed the class GlusterHostEntity to GlusterServerInfo, I
think a better name for this method is prepareServerInfo
Line 45: GlusterServerInfo entity = new GlusterServerInfo();
Line 46: entity.setHostName(map.get(HOST_NAME).toString());
Line 47: entity.setUuid(new Guid(map.get(UUID).toString()));
Line 48:
--
To view, visit http://gerrit.ovirt.org/7242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfacfdc5847e5d871da38d22b6b5efe86ea4d579
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
