Moti Asayag has posted comments on this change. Change subject: core: missing cluster policy validation ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37191/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java: Line 88: final ClusterValidator validator = new ClusterValidator(getDbFacade(), getVdsGroup()); Line 89: Line 90: if (!validateClusterPolicy()) { Line 91: return false; Line 92: } for the sake of backward comparability, shouldn't this validation be added at the end ? Line 93: Line 94: return validate(validator.nameNotUsed()) Line 95: && validate(validator.cpuTypeSupportsVirtService()) Line 96: && validate(validator.versionSupported()) -- To view, visit http://gerrit.ovirt.org/37191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie84058decb0994c1981f77858ff62346884eeeff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
