Alon Bar-Lev has posted comments on this change. Change subject: aaa: Modify webadmin and userportal to use enginesso for authentication ......................................................................
Patch Set 12: (2 comments) good! I will test it today later. Now we should start work on the sso login page so that it will support what we had in term of negotiation for example, also we need to support password change per extension flags, and external authentication. what do you want to do first? http://gerrit.ovirt.org/#/c/36619/12/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java: Line 73: } catch (NamingException ex) { Line 74: log.error("Unable to close context", ex); Line 75: } Line 76: } Line 77: response.sendRedirect(request.getParameter("opaque")); I still do not understand why this cannot be in the try/catch block... unless something critical the following pattern should apply: f() { try { // "good" logic } catch () { // "bad" logic } finally() { // cleanup } } Line 78: } Line 79: http://gerrit.ovirt.org/#/c/36619/12/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java: Line 125: query.asyncCallback = new INewAsyncCallback() { Line 126: @Override Line 127: public void onSuccess(Object model, Object ReturnValue) { Line 128: // Redirect to SSO Logout after the user has logged out successfully on backend. Line 129: Window.Location.assign(GWT.getModuleBaseURL() + "sso/logout?"); //$NON-NLS-1$ ? is not required Line 130: } Line 131: }; Line 132: Line 133: frontend.logoffAsync(frontend.getLoggedInUser(), query); -- To view, visit http://gerrit.ovirt.org/36619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff0aee9d0f5ee606ff7f397cab69017ca7d9df08 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
