Ramesh N has posted comments on this change.

Change subject: gluster: fix NPE in volume sync job
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/24430/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/gluster/GlusterCoreUtil.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/gluster/GlusterCoreUtil.java:

Line 60:      * @param brickDir
Line 61:      * @return
Line 62:      */
Line 63:     public static GlusterBrickEntity 
findBrick(Collection<GlusterBrickEntity> bricks, Guid serverId, String 
brickDir) {
Line 64:         for (GlusterBrickEntity brick : bricks) {
ObjectUtils.objectsEqual(a, b) may help here.
Line 65:             if (brick.getServerId() != null && 
brick.getServerId().equals(serverId)
Line 66:                     && brick.getBrickDirectory().equals(brickDir)) {
Line 67:                 return brick;
Line 68:             }


-- 
To view, visit http://gerrit.ovirt.org/24430
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I063569a3452a5c898a5a16791aff9ad409caf1cc
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to