David Caro has posted comments on this change. Change subject: Implementation of machine dialog parser for python ......................................................................
Patch Set 4: Code-Review+1 Looks ok to me, what's the reason of assuming binary streams instead of file-like objects? (with readline method, that is actually what you are implementing again anyhow) -- To view, visit http://gerrit.ovirt.org/28180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b715a39840e548ef768ac9e77004cc0d98a9c0 Gerrit-PatchSet: 4 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Lukas Bednar <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Lukas Bednar <[email protected]> Gerrit-Reviewer: Nelly Credi <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
