Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: removed incorrect value change handler ......................................................................
webadmin: removed incorrect value change handler The same handler has been registerd both on the ListModelTypeAheadListBox and on BaseListModelSuggestBox (using the addValueChangeHandler). The deleted one had no meaning - it's logic is handled by the SuggestBoxFocusHandler but in some cases kicked in sooner than the one in BaseListModelSuggestBox hiding the suggestions sooner than the correct handler was able to use them. Change-Id: I203023384e0d29671220d9ebd2ed7c4fd4b67da3 Bug-Url: https://bugzilla.redhat.com/1166022 Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java 1 file changed, 0 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/37243/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java index 650d2a2..f933855 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java @@ -130,17 +130,6 @@ // no need to do additional switchSuggestions() - it is processed by MenuBar itself getSuggestionMenu().getParent().addDomHandler(new FocusHandlerEnablingMouseHandlers(handlers), MouseUpEvent.getType()); - asSuggestBox().addValueChangeHandler(new ValueChangeHandler<String>() { - @Override - public void onValueChange(ValueChangeEvent<String> event) { - // in case of other way changed the value (like clicking somewhere else when there is a correct value) - // hide the suggest box - if(isSuggestionListShowing()) { - hideSuggestions(); - } - } - }); - addValueChangeHandler(new ValueChangeHandler<T>() { @Override public void onValueChange(ValueChangeEvent<T> event) { -- To view, visit http://gerrit.ovirt.org/37243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I203023384e0d29671220d9ebd2ed7c4fd4b67da3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
