Maor Lipchuk has posted comments on this change. Change subject: core: DetachDiskFromVmCommand ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37231/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-01-22 16:21:36 +0200 Line 4: Commit: Ala Hino <[email protected]> Line 5: CommitDate: 2015-01-22 16:21:36 +0200 Line 6: Line 7: core: DetachDiskFromVmCommand Please elaborate more in the commit message. for example: core: Use failCanDoAction method to fail a CDA Use one liner failure of failCanDoAction instead calling two operations of adding can do action message and return false. Line 8: Line 9: Minor fix. Line 10: Line 11: Change-Id: I111ee52cb967ab97f1614b2b00bcfa9346a0f3b0 -- To view, visit http://gerrit.ovirt.org/37231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I111ee52cb967ab97f1614b2b00bcfa9346a0f3b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
