Hello Idan Shaby,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/37277
to review the following change.
Change subject: webadmin: Fix running concurrent GetImagesList calls
......................................................................
webadmin: Fix running concurrent GetImagesList calls
When navigating to the Images subtab of an ISO storage domain, the
method syncSearch is called. In case one makes another similar request,
e.g., by clicking on another ISO domain, the new request gets
blocked. In this case, the ISOs belonging to the first domain are
displayed for the second domain.
This patch enables concurrent requests to be executed without being
blocked, and thus makes it possible for the new request to override the
old images list with the new one.
Change-Id: Ib6df991f597b26c13395907e99dd03934123e9b7
Bug-Url: https://bugzilla.redhat.com/1129267
Signed-off-by: Idan Shaby <[email protected]>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
1 file changed, 0 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/37277/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
index 77b3a01..fbbfbdc 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java
@@ -90,11 +90,6 @@
super.syncSearch();
- if (getProgress() != null)
- {
- return;
- }
-
StorageDomain storageDomain = (StorageDomain) getEntity();
boolean isDomainActive = storageDomain.getStorageDomainSharedStatus()
== StorageDomainSharedStatus.Active ||
storageDomain.getStorageDomainSharedStatus() ==
StorageDomainSharedStatus.Mixed;
--
To view, visit http://gerrit.ovirt.org/37277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6df991f597b26c13395907e99dd03934123e9b7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Amit Aviram <[email protected]>
Gerrit-Reviewer: Idan Shaby <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
