Allon Mureinik has posted comments on this change. Change subject: core: Use new permission for LSM ......................................................................
Patch Set 1: Code-Review-1 (2 comments) Missing the upgrade script. Also, see inline. http://gerrit.ovirt.org/#/c/37287/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java: Line 160: DiskImage diskImage = getDiskImageDao().get(parameters.getImageId()); Line 161: if (diskImage != null) { Line 162: permissionList.add(new PermissionSubject(diskImage.getId(), Line 163: VdcObjectType.Disk, Line 164: ActionGroup.CONFIGURE_DISK_STORAGE)); Should be REPLACED by DISK_LIVE_STORAGE_MIGRATION Line 165: permissionList.add(new PermissionSubject(diskImage.getId(), Line 166: VdcObjectType.Disk, Line 167: ActionGroup.DISK_LIVE_STORAGE_MIGRATION)); Line 168: } http://gerrit.ovirt.org/#/c/37287/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java: Line 106: CONFIGURE_DISK_STORAGE(1103, RoleType.USER, true, ApplicationMode.VirtOnly), Line 107: DELETE_DISK(1104, RoleType.USER, true, ApplicationMode.VirtOnly), Line 108: CONFIGURE_SCSI_GENERIC_IO(1105, RoleType.ADMIN, true, ApplicationMode.VirtOnly), Line 109: ACCESS_IMAGE_STORAGE(1106, RoleType.USER, false, ApplicationMode.VirtOnly), Line 110: DISK_LIVE_STORAGE_MIGRATION(1107, RoleType.ADMIN, true, ApplicationMode.VirtOnly), RoleType should be USER, like CONFIGURE_DISK_STORAGE. Line 111: Line 112: // VNIC Profiles Line 113: CONFIGURE_NETWORK_VNIC_PROFILE(1203, RoleType.ADMIN, true, ApplicationMode.VirtOnly), Line 114: CREATE_NETWORK_VNIC_PROFILE(1204, RoleType.ADMIN, true, ApplicationMode.VirtOnly), -- To view, visit http://gerrit.ovirt.org/37287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ba7e03780ba6ef455447a4eaa34a71b1f63d8cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
