Roy Golan has posted comments on this change. Change subject: core: make DbFacade a CDI singleton ......................................................................
Patch Set 37: (2 comments) general approach for overcomming jboss 7.1.1 bug is +1. we have no other magic currently. can you please separate the part with the module loading and deltaspike to a separate patch? would be much easier to track changes http://gerrit.ovirt.org/#/c/34814/37/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ModuleConfigurationExtension.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ModuleConfigurationExtension.java: Line 35: */ Line 36: void readAllConfigurations(final @Observes BeforeBeanDiscovery bdd, BeanManager bm) { Line 37: log.info("Starting to load beans from modules"); Line 38: addBeansFromPackage(bdd, bm, "org.ovirt.engine.core.dal"); Line 39: addBeansFromPackage(bdd, bm, "org.ovirt.engine.core.dao"); > Excellent point, and we did have issues with that on the developer jobs. We so we need to make sure to beans.xml isn't there as long as we have the problem. that should work Line 40: } Line 41: Line 42: private void addBeansFromPackage(final BeforeBeanDiscovery bdd, BeanManager bm, String packageName) { Line 43: Reflections reflections = new Reflections(packageName); Line 52: Line 53: if (foundBeans.size() == 0) { Line 54: bdd.addAnnotatedType(annotatedType); Line 55: String name; Line 56: Named named = bean.getAnnotation(Named.class); why Named is our marker for beans? its used to solve naming colision when using beans in web context, such as jsp pages and so on. it that necesarry or simlply currently a simple solution for marking beans for discovary? Line 57: if (named == null || Strings.isNullOrEmpty(named.value())) { Line 58: name = bean.getSimpleName(); Line 59: } else { Line 60: name = named.value(); -- To view, visit http://gerrit.ovirt.org/34814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9e57710ce8353af020cb5ae53e43b127276d6c6 Gerrit-PatchSet: 37 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
