Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/37320
to review the following change.
Change subject: core: JSON-RPC extend storage domain failure
......................................................................
core: JSON-RPC extend storage domain failure
The method extendStorageDomain used to build a RequestBuilder for the
"force" parameter using Boolean.toString instead of sending the force
parameter itself.
Change-Id: I25ceed4d093432af70b2f01157228c1773db561d
Bug-Url: https://bugzilla.redhat.com/1185865
Signed-off-by: Nir Soffer <[email protected]>
Signed-off-by: Fred Rolland <[email protected]>
Signed-off-by: Idan Shaby <[email protected]>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/37320/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
index ab8b3a9..5ff3bf5 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java
@@ -357,7 +357,7 @@
new
RequestBuilder("StorageDomain.extend").withParameter("storagedomainID", sdUUID)
.withParameter("storagepoolID", spUUID)
.withParameter("devlist", new
ArrayList<String>(Arrays.asList(devlist)))
- .withOptionalParameter("force",
Boolean.toString(force))
+ .withParameter("force", force)
.build();
Map<String, Object> response =
new FutureMap(this.client, request);
--
To view, visit http://gerrit.ovirt.org/37320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25ceed4d093432af70b2f01157228c1773db561d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <[email protected]>
Gerrit-Reviewer: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
