Allon Mureinik has posted comments on this change. Change subject: core: Fix storage allocation check when merging a snapshot ......................................................................
Patch Set 2: (1 comment) The master patch isn't merged yet - what's the point in backporting it? http://gerrit.ovirt.org/#/c/37255/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java: Line 878: DiskImage clone = DiskImage.copyOf(snapshot); Line 879: // Add the child snapshot into which the deleted snapshot is going to be merged to the Line 880: // DiskImage for StorageDomainValidator to handle Line 881: List<DiskImage> snapshots = DbFacade.getInstance().getDiskImageDao().getAllSnapshotsForParent(clone.getImageId()); Line 882: clone.getSnapshots().clear(); Didn't we decide we're moving away from this? Line 883: clone.getSnapshots().add(clone); // Add the clone itself since snapshots should contain the entire chain. Line 884: clone.getSnapshots().addAll(snapshots); Line 885: diskDummies.add(clone); Line 886: } -- To view, visit http://gerrit.ovirt.org/37255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41213884ed0ca9ddf8354ab7be58f032a6d90673 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
