Lior Vernia has posted comments on this change. Change subject: webadmin: ClusterNetworkManageModel - add management column ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/36403/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkManageModel.java: Line 108: } Line 109: Line 110: private ClusterNetworkModel getManagementNetwork() { Line 111: if (!isMultiCluster()) { Line 112: for (ClusterNetworkModel clusterNetworkManageModel : getItems()) { Why not find the management network when first populating the model, and then keep a reference to it instead of re-running this loop? Line 113: if (clusterNetworkManageModel.isManagement()) { Line 114: return clusterNetworkManageModel; Line 115: } Line 116: } http://gerrit.ovirt.org/#/c/36403/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java: Line 356: } Line 357: Line 358: @Override Line 359: protected boolean canEdit(ClusterNetworkModel clusterNetworkModel) { // TODO Line 360: return clusterNetworkModel.isAttached() && !clusterNetworkModel.isExternal(); Shouldn't this also block editing if multipleSelectionAllowed && isManagement? Line 361: } Line 362: } Line 363: Line 364: private final class ManagementNetworkIndicatorFieldUpdater implements FieldUpdater<ClusterNetworkModel, Boolean> { -- To view, visit http://gerrit.ovirt.org/36403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3153d4aec549b847ef209ea28b36d0329e06a7a9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
