Martin Mucha has posted comments on this change. Change subject: userportal,webadmin:change Translator to interface ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/26596/8/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java: Line 23: @Override Line 24: public String translate(Enum<?> key) { Line 25: if(key == null) { Line 26: logger.log(Level.INFO, "trying to localize null, probable error. " + Line 27: "Exception is not thrown, returning '"+ constants.notAvailableLabel()+"'", new RuntimeException()); > well, I'd expect that enum translation is used on many places, and method a Done Line 28: return constants.notAvailableLabel(); Line 29: } Line 30: Line 31: try { -- To view, visit http://gerrit.ovirt.org/26596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib018c1faf0c2e1ebaa81217d5e3696d9c8de20cf Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
