Martin Mucha has posted comments on this change. Change subject: core: command for updating template nics. ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/35285/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractUpdateNicsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractUpdateNicsCommand.java: Line 39: UpdateNicsVmInterfaceParametersFactory parameters = calculateRequiredParameters(getExistingNics()); Line 40: Line 41: invokeActionType(VdcActionType.AddVmInterface, parameters.createVnicParameters); Line 42: invokeActionType(VdcActionType.UpdateVmInterface, parameters.updateVnicParameters); Line 43: invokeActionType(VdcActionType.RemoveVmInterface, parameters.removeVnicParameters); > I agree. This code arose by series of refactorings from GUI code I just iso Done Line 44: Line 45: if (getParameters().reorderNics) { Line 46: VmOperationParameterBase reorderParams = new VmOperationParameterBase(getParameters().vmId); Line 47: runInternalAction(VdcActionType.ReorderVmNics, reorderParams); -- To view, visit http://gerrit.ovirt.org/35285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf67d6e0aeb094859f7eb1930bb151164f5207be Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
