Martin Mucha has posted comments on this change. Change subject: core: AuditLogDirector should not have static methods ......................................................................
Patch Set 13: (1 comment) http://gerrit.ovirt.org/#/c/29589/13/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfStoresForStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvfStoresForStorageDomainCommand.java: Line 85: } else { Line 86: getBackend().endAction(p.getCommandType(), Line 87: p, Line 88: getContext().clone().withoutCompensationContext().withoutExecutionContext().withoutLock()); Line 89: new AuditLogDirector().log(this, AuditLogType.CREATE_OVF_STORE_FOR_STORAGE_DOMAIN_FAILED); > it's hard to tell(for me). Someone would what this in this patch (you), som Done Line 90: } Line 91: } Line 92: Line 93: if (atleastOneSucceeded) { -- To view, visit http://gerrit.ovirt.org/29589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id88ecd68fdc469bd0ddfdf4ae9c7f6d22ff8e8bf Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
