Shubhendu Tripathi has posted comments on this change.

Change subject: webadmin: Listing gluster volume snapshots
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/36628/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java:

Line 153:             "</tr> </table>")
Line 154:     SafeHtml volumeBrickStatusTemplate(SafeHtml upImage, int upCount, 
SafeHtml downImage, int downCount);
Line 155: 
Line 156:     @Template("<div style='line-height: 100%; text-align: center; 
vertical-align: middle;'>{0}</div>")
Line 157:     SafeHtml volumeSnapshotsStatusTemplate(int snapshotCount);
> is this being used?
Its not used now. Will remove this.
Earlier it was done this way, but removed later.
Line 158: 
Line 159:     @Template("<div style='line-height: 100%; text-align: center; 
vertical-align: middle; border: solid 1px transparent; '>{0}</div>")
Line 160:     SafeHtml volumeActivityMenu(SafeHtml statusImage);
Line 161: 


-- 
To view, visit http://gerrit.ovirt.org/36628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1953aad3d013d386719a43b4bfdda82896cc3af
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to