Shubhendu Tripathi has posted comments on this change. Change subject: gluster: vdc query for gettting un used bricks ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/36039/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetUnusedBricksQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetUnusedBricksQuery.java: Line 26: } Line 27: Line 28: private List<StorageDevice> getUnsedBricks(List<StorageDevice> bricksFromServer) { Line 29: List<GlusterBrickEntity> usedBricks = Line 30: DbFacade.getInstance() Add a method in QueriesCommandBase to return the DAO and use the same here. Not mandatory though. Line 31: .getGlusterBrickDao() Line 32: .getGlusterVolumeBricksByServerId(getParameters().getVdsId()); Line 33: List<StorageDevice> freeBricks = new ArrayList<StorageDevice>(); Line 34: Set<String> bricksDir = new HashSet<String>(); -- To view, visit http://gerrit.ovirt.org/36039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida1563018939aa7e8160045c8e320ddab083c1fc Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
