Sahina Bose has posted comments on this change. Change subject: engine : Entity and DAO changes for Disk provisioning ......................................................................
Patch Set 4: (2 comments) Please add Dao test http://gerrit.ovirt.org/#/c/36428/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageDevice.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageDevice.java: Line 18: private String devPath; Line 19: private String fsType; Line 20: private String mountPoint; Line 21: private Long size; Line 22: private Boolean canCreateBrick; Is it better to have a status on StorageDevice instead? There could be a status that indicates that brick can be created from this storage device. Just a suggestion in case you want to differentiate the various stat Line 23: Line 24: public StorageDevice() { Line 25: super(); Line 26: } Line 159: return false; Line 160: if (getClass() != obj.getClass()) Line 161: return false; Line 162: StorageDevice other = (StorageDevice) obj; Line 163: if (canCreateBrick == null) { Use ObjectUtils helper for this Line 164: if (other.canCreateBrick != null) Line 165: return false; Line 166: } else if (!canCreateBrick.equals(other.canCreateBrick)) Line 167: return false; -- To view, visit http://gerrit.ovirt.org/36428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95a12239429dd0c7f3282161221e8b8f639cee9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
