Tal Nisan has posted comments on this change. Change subject: core: Report storage size closer to reality ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37428/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/StorageSizeLabel.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/StorageSizeLabel.java: Line 10 Line 11 Line 12 Line 13 Line 14 > iirc, there are cases when size 0 means unknown which we should display as I think we should leave this class as is and use another renderer that will render 0 as zero for specific places cause if we change this label now we might end up changing places that should render 0 as N/A to work incorrectly since this N/A was made for a reason -- To view, visit http://gerrit.ovirt.org/37428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I758febd3b6b1a1f13ae4e48635bf185ea81d918b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
