Roy Golan has posted comments on this change.
Change subject: core: VmsMonitoring - remove unmodifiableList
......................................................................
Patch Set 1:
omg. my bad.
going forward I'd like the vmanalyzer just to hold the data inside and let
vmsMonitoring gather it.
so in analyzer do
private List<LUNs> luns;
....
luns.add(lunFromDb)
and then iterate at VmsMonitoring
for analyzer in analyzers {
vmLunDisksToSave.addAll(analyzer.getLuns())
}
--
To view, visit http://gerrit.ovirt.org/37425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I48cd27d7ba2f1fe658f5c2cb308e0ba9dbe1c798
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
