Lior Vernia has uploaded a new change for review. Change subject: webadmin: "None" QoS where appropriate ......................................................................
webadmin: "None" QoS where appropriate For the link share and real time fields of Host Network QoS, "Unlimited" is not the appropriate term as they do not specify a limit. Change-Id: Ib51f10d37240d06eb3ba11a2f99e2490ad74c717 Bug-Url: https://bugzilla.redhat.com/1182130 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterHostNetworkQosView.java 2 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/37451/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java index 8896ffa..3533096 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java @@ -1740,6 +1740,9 @@ @DefaultStringValue("Unlimited") String unlimitedQos(); + @DefaultStringValue("None") + String noneQos(); + @DefaultStringValue("Password") String hostPasswordLabel(); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterHostNetworkQosView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterHostNetworkQosView.java index dbf322e..ccf934e 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterHostNetworkQosView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/datacenter/SubTabDataCenterHostNetworkQosView.java @@ -64,7 +64,7 @@ TextColumnWithTooltip<HostNetworkQos> outAverageLinkshareColumn = new TextColumnWithTooltip<HostNetworkQos>() { @Override public String getValue(HostNetworkQos object) { - return object.getOutAverageLinkshare() == null ? constants.unlimitedQos() + return object.getOutAverageLinkshare() == null ? constants.noneQos() : object.getOutAverageLinkshare().toString(); } }; @@ -84,7 +84,7 @@ TextColumnWithTooltip<HostNetworkQos> outAverageRealtimeColumn = new TextColumnWithTooltip<HostNetworkQos>() { @Override public String getValue(HostNetworkQos object) { - return object.getOutAverageRealtime() == null ? constants.unlimitedQos() + return object.getOutAverageRealtime() == null ? constants.noneQos() : object.getOutAverageRealtime().toString(); } }; -- To view, visit http://gerrit.ovirt.org/37451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib51f10d37240d06eb3ba11a2f99e2490ad74c717 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
