Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL query to get volume snapshot configurations ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/36292/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSnapshotConfigQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSnapshotConfigQuery.java: Line 25: Guid volumeId = getParameters().getVolumeId(); Line 26: List<GlusterVolumeSnapshotConfig> configs = Line 27: getGlusterVolumeSnapshotConfigDao().getConfigByClusterId(clusterId); Line 28: Line 29: List<GlusterVolumeSnapshotConfig> clusterCfgs = new ArrayList<GlusterVolumeSnapshotConfig>(); > Please use diamond ( <> ) operator when allocating a generic type. doen Line 30: List<GlusterVolumeSnapshotConfig> volumeCfgs = new ArrayList<GlusterVolumeSnapshotConfig>(); Line 31: Line 32: if (configs != null && configs.size() > 0) { Line 33: for (GlusterVolumeSnapshotConfig config : configs) { -- To view, visit http://gerrit.ovirt.org/36292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4374b51297549731bc6c93c8a72b033ca64fdfef Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
