Shubhendu Tripathi has posted comments on this change. Change subject: gluster: BLL command to set volume snapshot config ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/36294/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterVolumeSnapshotConfigCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterVolumeSnapshotConfigCommand.java: Line 49: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CLUSTER_IS_NOT_VALID); Line 50: return false; Line 51: } Line 52: Line 53: if (getParameters().getConfigParams() == null || getParameters().getConfigParams().size() == 0) { > use isEmpty, and not size() == 0 done Line 54: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_SNAPSHOT_CONFIG_PARAMS_IS_EMPTY); Line 55: return false; Line 56: } Line 57: Line 73: getGlusterVolumeSnapshotConfigDao().getConfigByClusterId(clusterId); Line 74: Line 75: // segregate the fetched cluster and volume specific config params Line 76: Map<String, GlusterVolumeSnapshotConfig> fetchedClusterConfigParams = Line 77: new HashMap<String, GlusterVolumeSnapshotConfig>(); > please use diamond operator. done Line 78: Map<String, GlusterVolumeSnapshotConfig> fetchedVolumeConfigParams = Line 79: new HashMap<String, GlusterVolumeSnapshotConfig>(); Line 80: for (GlusterVolumeSnapshotConfig param : fetchedConfigParams) { Line 81: if (Guid.isNullOrEmpty(param.getVolumeId())) { -- To view, visit http://gerrit.ovirt.org/36294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37b6f4dd02ca4258e5e40e7da11f0a657ac6b330 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
