Eli Mesika has posted comments on this change. Change subject: core : Add Entity API for CoCo commands ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/37463/1/packaging/dbscripts/command_entities_sp.sql File packaging/dbscripts/command_entities_sp.sql: Line 170: Line 171: RETURNS VOID Line 172: AS $procedure$ Line 173: BEGIN Line 174: IF NOT EXISTS (SELECT 1 from coco_cmd_entities where command_id = v_command_id and entity_id = v_entity_id) THEN why we should handle that in the DB layer ??? All other insertions generally do not check for existence , it makes the SQL operation more expensive .... Line 175: INSERT INTO coco_cmd_entities (command_id,entity_id,entity_type) VALUES (v_command_id, v_entity_id, v_entity_type); Line 176: END IF; Line 177: END; $procedure$ Line 178: LANGUAGE plpgsql; http://gerrit.ovirt.org/#/c/37463/1/packaging/dbscripts/upgrade/03_06_0830_add_coco_cmd_entities_table.sql File packaging/dbscripts/upgrade/03_06_0830_add_coco_cmd_entities_table.sql: Line 7: ALTER please use the fn_db_add_constraint function -- To view, visit http://gerrit.ovirt.org/37463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96b934ffc44f87407df77c8e097164ca30f3a6e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
