Tomas Jelinek has posted comments on this change. Change subject: core: Added a possibility to filter disks according explicitely set values ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/36060/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseGetAllAttachableDisksQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseGetAllAttachableDisksQuery.java: Line 9: Line 10: import java.util.ArrayList; Line 11: import java.util.List; Line 12: Line 13: public abstract class BaseGetAllAttachableDisksQuery<P extends GetAllAttachableDisks> extends QueriesCommandBase<P> { > Naming - I would suggest BaseGetAttachableDisksQuery, as it's supposed to b Done Line 14: Line 15: public BaseGetAllAttachableDisksQuery(P parameters) { Line 16: super(parameters); Line 17: } http://gerrit.ovirt.org/#/c/36060/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAttachableDisksFilteredByExplicitValuesQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllAttachableDisksFilteredByExplicitValuesQuery.java: Line 4: import org.ovirt.engine.core.common.queries.GetAllAttachableDisksFilteredByExpliciteValues; Line 5: Line 6: import java.util.List; Line 7: Line 8: public class GetAllAttachableDisksFilteredByExplicitValuesQuery<P extends GetAllAttachableDisksFilteredByExpliciteValues> extends BaseGetAllAttachableDisksQuery<P> { > The "All" here bothers me. How about: GetFilteredAttachableDisks ? Shorter Done Line 9: Line 10: public GetAllAttachableDisksFilteredByExplicitValuesQuery(P parameters) { Line 11: super(parameters); Line 12: } http://gerrit.ovirt.org/#/c/36060/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllAttachableDisksFilteredByExpliciteValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllAttachableDisksFilteredByExpliciteValues.java: Line 2: Line 3: import org.ovirt.engine.core.compat.Guid; Line 4: import org.ovirt.engine.core.compat.Version; Line 5: Line 6: public class GetAllAttachableDisksFilteredByExpliciteValues extends GetAllAttachableDisks { > Same issue with the naming - GetFilteredAttachableDisks ? Done Line 7: Line 8: private int os; Line 9: Line 10: private Version vdsGroupCompatibilityVersion; -- To view, visit http://gerrit.ovirt.org/36060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If363cd92aa0071c88f2333294002ff8aa0da1b40 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
