Tomas Jelinek has posted comments on this change. Change subject: webadmin: moved the remove disk related logic into the RemoveDiskModel ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/35420/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java: Line 403: Line 404: boolean hasSystemDiskWarning = false; Line 405: RemoveDiskModel model = new RemoveDiskModel(); Line 406: setWindow(model); Line 407: model.initialize(getEntity(), getSelectedItems(), this); > same should be done for 'Disks main-tab -> remove' (DiskListModel) good catch, thanx! Done Line 408: } Line 409: Line 410: private void onRemove() { Line 411: RemoveDiskModel model = (RemoveDiskModel) getWindow(); Line 411: RemoveDiskModel model = (RemoveDiskModel) getWindow(); Line 412: if (!model.validate()) { Line 413: return; Line 414: } Line 415: model.store(this); > rename to 'onRemove' (just to keep the convention...) Done Line 416: } Line 417: Line 418: private void plug() { Line 419: Frontend.getInstance().runMultipleAction(VdcActionType.HotPlugDiskToVm, createHotPlugDiskToVmParameters(true), -- To view, visit http://gerrit.ovirt.org/35420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ea61be0b8ee30b509056ebf8bf8235e5980f8cd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
