Yevgeny Zaspitsky has posted comments on this change. Change subject: webadmin: ClusterNetworkManageModel - add management column ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/36403/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java: Line 356: } Line 357: Line 358: @Override Line 359: protected boolean canEdit(ClusterNetworkModel clusterNetworkModel) { // TODO Line 360: return clusterNetworkModel.isAttached() && !clusterNetworkModel.isExternal(); > Shouldn't this also block editing if multipleSelectionAllowed && isManageme Then it'd make IMHO bad user experience in the following scenario: 0. multipleSelectionAllowed == true 1. initially isn't management row 2. user makes it management, but doesn't submit 3. we block editing of the row, user cannot revert his change unless he cancel all the changes he made in the screen. I guess we should leave blocking of unsetting management for the backend logic, where we see the whole picture. Line 361: } Line 362: } Line 363: Line 364: private final class ManagementNetworkIndicatorFieldUpdater implements FieldUpdater<ClusterNetworkModel, Boolean> { -- To view, visit http://gerrit.ovirt.org/36403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3153d4aec549b847ef209ea28b36d0329e06a7a9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
