Alex Lourie has posted comments on this change. Change subject: packaging: Added functions references for cleaner code. ......................................................................
Patch Set 1: No score (1 inline comment) .................................................... File packaging/fedora/setup/engine-upgrade.py Line 709: Line 710: # Functions/parameters definitions Line 711: stopEngineService = [stopEngine] Line 712: upgradeFunc = [rhyum.update] Line 713: postFunc = [runPost] no, you right, just one needed. Fixed. Line 714: engineService = basedefs.ENGINE_SERVICE_NAME Line 715: Line 716: if unsupportedVersionsPresent(): Line 717: print MSG_ERROR_INCOMPATIBLE_UPGRADE -- To view, visit http://gerrit.ovirt.org/7465 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8fec87bf8dc99e990cb62d85e2915246f38fbac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
