Eli Mesika has posted comments on this change. Change subject: webadmin: When creating LUN disk populate the description with the LUN id ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/37088/7/packaging/etc/engine-config/engine-config.properties File packaging/etc/engine-config/engine-config.properties: Line 21: CpuOverCommitDurationMinutes.description="The duration in minutes of CPU consumption to activate selection algorithm" Line 22: CpuOverCommitDurationMinutes.type=Integer Line 23: DisableFenceAtStartupInSec.description="Disable Fence Operations At oVirt Startup In Seconds" Line 24: DisableFenceAtStartupInSec.type=Integer Line 25: PopulateDirectLUNDiskDescriptionWithLUNId.description="When creating direct LUN disk the number of characters from LUN id to populate the description with (-1 = the full id, 0 = none, <0 = number of characters)" <0 = number of characters IMO you mean > 0 right ? Also what happens if a number > LUN ID length is given ??? Line 26: PopulateDirectLUNDiskDescriptionWithLUNId.type=Integer Line 27: ClusterEmulatedMachines.description="Supported machine types" Line 28: WANDisableEffects.description="Disabled WAN Effects value to send to the SPICE console" Line 29: WANDisableEffects.validValues=animation,wallpaper,font-smooth,all -- To view, visit http://gerrit.ovirt.org/37088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife497d61e4799dec5db6b8fc5007cac743969b2b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
