Nir Soffer has posted comments on this change. Change subject: vdsm: use vdscli instead of vdsClient for storage operations ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36798/3/src/plugins/ovirt-hosted-engine-setup/storage/storage.py File src/plugins/ovirt-hosted-engine-setup/storage/storage.py: Line 718: ] = self.dialog.queryString( Line 719: name='OVEHOSTED_STORAGE_DATACENTER_NAME', Line 720: note=_( Line 721: 'Local storage datacenter name is an internal name ' Line 722: 'and currently will not be shown in engine\'s admin UI.\n' > Sorry, I don't understand. Sorry, this change came from a rebase, it looked like part of your patch when I checked the changes between version 2 and 3. Line 723: 'Please enter local datacenter name [@DEFAULT@]: ' Line 724: ), Line 725: prompt=True, Line 726: caseSensitive=True, -- To view, visit http://gerrit.ovirt.org/36798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec7db5ccf55752266fa668a8b1e8f914cd632521 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
