Piotr Kliczewski has posted comments on this change. Change subject: engine: Correct VDS geo-rep status ......................................................................
Patch Set 3: Code-Review-1 Is there any reason to only update method names in VdsServerConnector interface which is only used xmlrpc proxy object? When doing changes like that please consider changing IVdsServer as well. I understand that the return value is different and we changed response marshaling code in *XmlRpc so what about jsonrpc related code? Please take a look at JsonRpcVdsServer. How this change will affect backward compatibility? -- To view, visit http://gerrit.ovirt.org/37390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7449d6a786f3bae55752eb25f36f6210448cdd83 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
