Allon Mureinik has posted comments on this change. Change subject: core: Fix import from glance storage allocation check ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/37505/1//COMMIT_MSG Commit Message: Line 13: the aforementioned method), which resulted in a disk size of 0. Line 14: This patch adds the image to the snapshots. Line 15: Line 16: Change-Id: I02d1cfb30c64a7d7b7b4c0386b134583faee190d Line 17: Bug-Url: https://bugzilla.redhat.com/1178012 Should probably reference the oVirt bug https://bugzilla.redhat.com/1053750 http://gerrit.ovirt.org/#/c/37505/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java: Line 249: if (diskImage == null) { Line 250: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_DISK_NOT_EXIST); Line 251: } Line 252: Line 253: Why is this related to the patch? Line 254: return validateSpaceRequirements(diskImage); Line 255: } Line 256: Line 257: protected boolean validateSpaceRequirements(DiskImage diskImage) { -- To view, visit http://gerrit.ovirt.org/37505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02d1cfb30c64a7d7b7b4c0386b134583faee190d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
