Sandro Bonazzola has uploaded a new change for review. Change subject: vm: image: always preallocate volume ......................................................................
vm: image: always preallocate volume Thin provisioned volumes are supported only on NFS. It's also good to ensure that the volume won't hit no space left issues while trying to grow the thin provisioned disk. Change-Id: Icbeb48ee98a1c525a631690b6f11b22081b57b75 Signed-off-by: Sandro Bonazzola <[email protected]> --- M src/plugins/ovirt-hosted-engine-setup/vm/image.py 1 file changed, 1 insertion(+), 8 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-setup refs/changes/12/37512/1 diff --git a/src/plugins/ovirt-hosted-engine-setup/vm/image.py b/src/plugins/ovirt-hosted-engine-setup/vm/image.py index 4617a8d..776af51 100644 --- a/src/plugins/ovirt-hosted-engine-setup/vm/image.py +++ b/src/plugins/ovirt-hosted-engine-setup/vm/image.py @@ -219,13 +219,6 @@ self.logger.info(_('Creating VM Image')) self.logger.debug('createVolume') volFormat = ohostedcons.VolumeFormat.RAW_FORMAT - preallocate = ohostedcons.VolumeTypes.SPARSE_VOL - if self.environment[ohostedcons.StorageEnv.DOMAIN_TYPE] in ( - ohostedcons.DomainTypes.ISCSI, - ): - # Can't use sparse volume on block devices - preallocate = ohostedcons.VolumeTypes.PREALLOCATED_VOL - diskType = 2 status, message = serv.createVolume([ sdUUID, @@ -233,7 +226,7 @@ imgUUID, self.environment[ohostedcons.StorageEnv.IMAGE_SIZE_GB], volFormat, - preallocate, + ohostedcons.VolumeTypes.PREALLOCATED_VOL, diskType, volUUID, self.environment[ohostedcons.StorageEnv.IMAGE_DESC], -- To view, visit http://gerrit.ovirt.org/37512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icbeb48ee98a1c525a631690b6f11b22081b57b75 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
