Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: refactor use of PatternFly grid classes ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/37502/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java: Line 110: informationMessagePanel.setVisible(false); Line 111: passwordEditor.setAutoComplete("off"); //$NON-NLS-1$ Line 112: Line 113: userNameEditor.addLabelStyleName(PatternflyConstants.COL_SM_2); Line 114: userNameEditor.addLabelStyleName(PatternflyConstants.COL_MD_2); > Out of curiosity, how is the screen size resolved? Is our project already r It works based on pixel size. In theory, every app uses all sizes. It only matters how wide the user has the window. sm means when the screen is > 768px wide. Idea being, you may want totally different layouts when screen size changes. Descriptions of the other sizes here: http://www.w3schools.com/bootstrap/bootstrap_grid_system.asp You question made me realize that col-md-x is redundant here because the classes "scale up." Unless -md is different than -sm, no need for -md. Removed in patchset 2. (We used to use a different value for -md and I just forgot to remove it). So essentially this means -- use 2/10 column split when screen width >= 768. Line 115: userNameEditor.addLabelStyleName(PatternflyConstants.CONTROL_LABEL); Line 116: userNameEditor.addLabelStyleName("white"); //$NON-NLS-1$ Line 117: userNameEditor.addContentWidgetContainerStyleName(PatternflyConstants.COL_SM_10); Line 118: userNameEditor.addContentWidgetContainerStyleName(PatternflyConstants.COL_MD_10); Line 114: userNameEditor.addLabelStyleName(PatternflyConstants.COL_MD_2); Line 115: userNameEditor.addLabelStyleName(PatternflyConstants.CONTROL_LABEL); Line 116: userNameEditor.addLabelStyleName("white"); //$NON-NLS-1$ Line 117: userNameEditor.addContentWidgetContainerStyleName(PatternflyConstants.COL_SM_10); Line 118: userNameEditor.addContentWidgetContainerStyleName(PatternflyConstants.COL_MD_10); > So I'll be able to implement such layouts myself - what basically happens i Yeah. I'm not sure about every element -- technically you're supposed to put the cols inside rows. <div class="row"> cols here </div> Analogous to tr / td I suppose. But you have the idea. Alexander is actually implementing this in some dialogs now, so he'll have more advice than me. Line 119: Line 120: passwordEditor.addLabelStyleName(PatternflyConstants.COL_SM_2); Line 121: passwordEditor.addLabelStyleName(PatternflyConstants.COL_MD_2); Line 122: passwordEditor.addLabelStyleName(PatternflyConstants.CONTROL_LABEL); -- To view, visit http://gerrit.ovirt.org/37502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7eb9241a8800343174d2e23cbd33c26b9fe31f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
