Greg Sheremeta has posted comments on this change. Change subject: webadmin: Host General sub tab ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/37387/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java: Line 91: } Line 92: Line 93: @SuppressWarnings("unchecked") Line 94: @Override Line 95: public void prepareFromRequest(PlaceRequest request) { this looks like the part that fixes that rendering bug. And it looks like it's used by QOS and General now. Are there other places that should be refactored to use the logic here? Line 96: super.prepareFromRequest(request); Line 97: Line 98: if (getProxy() instanceof TabContentProxyPlace && getMainTabRequest() != null) { Line 99: // Reveal presenter only when there is something selected in the main tab -- To view, visit http://gerrit.ovirt.org/37387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie70cee7d4c5742a51ba6084968cf8617d0e2680e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
