Eli Mesika has posted comments on this change.

Change subject: core: Improve performance of 
GetStorageConnectionsByStorageTypeAndStatus
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/37528/2/packaging/dbscripts/storages_san_sp.sql
File packaging/dbscripts/storages_san_sp.sql:

Line 535: DECLARE
Line 536:   statuses int[];
Line 537: BEGIN
Line 538: statuses := string_to_array(v_statuses,',')::integer[];
Line 539: RETURN QUERY SELECT * 
same,

+1 ,

Please remove TWS
Line 540:    FROM storage_server_connections
Line 541:    WHERE (v_storage_type is NULL or connections.storage_type = 
v_storage_type) 
Line 542:    AND (id in (select storage from storage_domains where 
storage_domains.storage_pool_id = v_storage_pool_id and storage_domains.status 
= any(statuses)) 
Line 543:    OR (id in (select 
lun_storage_server_connection_map.storage_server_connection


-- 
To view, visit http://gerrit.ovirt.org/37528
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8048b87fa321086469c892c3650f7c5548cc13d8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to