Yair Zaslavsky has posted comments on this change. Change subject: engine: Get Server fingerprint query ......................................................................
Patch Set 9: I would prefer that you didn't submit this (1 inline comment) Changing to -1 Took me 2nd review to see we're have typo mistake all over. Finerprint should be Fingerprint .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java Line 274: GetGlusterVolumeById, Line 275: GetGlusterVolumeOptionsInfo, Line 276: GetGlusterVolumeBricks, Line 277: GetGlusterBrickById, Line 278: GetServerSSHKeyFinerprint, Typo, replace Finerprint with Fingerprint Line 279: Line 280: // Default type instead of having to null check Line 281: Unknown(VdcQueryAuthType.User); Line 282: -- To view, visit http://gerrit.ovirt.org/7034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8241e54a6f1b6d649a0c23f18ef6ba216670f005 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dhandapani Gopal <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Selvasundaram <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
